Closed HexDecimal closed 1 year ago
Merging #182 (41ebb89) into master (7e05593) will decrease coverage by
0.30%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 95.47% 95.18% -0.30%
==========================================
Files 14 14
Lines 1084 1267 +183
==========================================
+ Hits 1035 1206 +171
- Misses 49 61 +12
Impacted Files | Coverage Δ | |
---|---|---|
delocate/tools.py | 94.78% <100.00%> (-1.34%) |
:arrow_down: |
... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@matthew-brett GitHub Actions has dropped support for macos-10.15
, this will affect test coverage.
Merged since tests can't run with this PR and the fix has been verified.
The
unzip
command on MacOS does not seem to handle Python's UTF-8 locale correctly. Runningunzip -q
should skip outputting these non-ASCII filenames in otherwise working runs.In theory this change may also improve the performance of large archives.
Fixes #181