search

matthewfeickert / R-in-Jupyter-with-Binder

Example of how to use R in Jupyter notebooks and make compatible with Binder
BSD 3-Clause "New" or "Revised" License
17 stars 6 forks source link

Add syntax highlighting hints and apply R stdout style #17

Closed matthewfeickert closed 5 years ago

matthewfeickert commented 5 years ago

It is isn't as obvious what is stdout and what is input and that this style change, which is common in the R community, makes this clear. Adding syntax highlighting make this even more clean as it makes things pop out a bit more. :+1:

matthewfeickert commented 5 years ago

@RaoOfPhysics I think this is the only instance of output from a command in the README, and this should now address your very good comment. :+1:

RaoOfPhysics commented 5 years ago

Looks good to me!

I might propose a PR that explicitly marks out which statements need to be executed in the shell and which ones within R. I can also modify the fenced codeblocks with the syntax highlighting for the code:

```r
packrat::status()

or

````markdown
```sh
R -e 'install.packages("packrat")'
matthewfeickert commented 5 years ago

Ah great! I didn't know that the R syntax highlighting was available on GitHub. Yeah, given that this PR is so minimial (1 line) I might as well just revise this to be an R style PR. As this

packrat::status()
R -e 'install.packages("packrat")'

obviously looks nicer. :)

RaoOfPhysics commented 5 years ago

Works for me! And makes my life simpler. ;)

matthewfeickert commented 5 years ago

@RaoOfPhysics Thanks for making a great point and providing really helpful feedback! :+1: