search

matthewgilbert / pdblp

pandas wrapper for Bloomberg Open API
MIT License
242 stars 67 forks source link

BSRCH function #12

Closed MarekOzana closed 7 years ago

MarekOzana commented 7 years ago

pdblp.py BCon.start(): adding //blp/exrsrc service BCon.sbrch(): implemented

test_pdblp.py test_bsrch(): implemented updated test_bdib(): intraday data older than 6M are not accessible. Using 2017-06-10 instead

test_parser.py please disregard. All tests were failing for me (evenprior to my changes). So I just added skip.

flake8 passes without any issue. All tests in test_pdblp.py are passing.

11

matthewgilbert commented 7 years ago

This looks good. Could you please just remove the skip decorator from the parsing tests and squash the history into one commit? (I'm curious why this is failing for you, possibly because you aren't using pyparsing >= 2.2.0)

MarekOzana commented 7 years ago

You are right, upgrading to pyparsing 2.2.0 fixed the remaining tests. I removed the skip from test_parser. Now all tests are passing.

It is the first time I used squashing, seems that I touched too many of old commits as well ;( I hope you can merge it now.

matthewgilbert commented 7 years ago

Okay cleaned something up and merged from command line. Thanks looks great! This closes issue #11 .

matthewgilbert commented 7 years ago

@MarekOzana not sure why you aren't being credited for this on the contributors page. I'm looking into it, but think maybe it has to do with emails https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/

matthewgilbert commented 7 years ago

So it seems like this is because the @ outlook email used in the commits is not associated with your account. The easiest way is to link the email to your account with https://github.com/settings/emails. Not sure if this matters to you but just thought I'd pass the info along in case.

MarekOzana commented 7 years ago

Thanks Matthew. I've update e-mail settings now. /Marek