matthewholman / assist

ASSIST is a software package for ephemeris-quality integrations of test particles.
https://assist.readthedocs.io/
GNU General Public License v3.0
24 stars 10 forks source link

Unit test for non-gravitational forces #46

Closed hannorein closed 1 year ago

hannorein commented 1 year ago

Do you have an example (from the paper) that we can use as a unit test for the non-gravitational forces?

Note that I haven't put much thought into how to handle the parameters for the non-gravitational forces (A1 A2 A3). I think just letting the user setup an array an passing that to assist would be the easiest. So basically what's already there - with a few modifications for using it with the plain interface.

matthewholman commented 1 year ago

Yes, Apophis has non-gravitational forces. The Apophis notebook in the jupyter_examples directory is a good place to start. The A1, A2, A3 constants are passed in in an array.

Related to that, there is a part of the non-gravs that still needs work but not urgently. The radial function g(r) has a parameterization internally, but current the parameters are not adjustable from the outside. That is g(r) ~ 1/r^2, which is the typical case.

On Fri, Feb 3, 2023 at 11:59 AM Hanno Rein @.***> wrote:

Do you have an example (from the paper) that we can use as a unit test for the non-gravitational forces?

Note that I haven't put much thought into how to handle the parameters for the non-gravitational forces (A1 A2 A3). I think just letting the user setup an array an passing that to assist would be the easiest. So basically what's already there - with a few modifications for using it with the plain interface.

— Reply to this email directly, view it on GitHub https://github.com/matthewholman/assist/issues/46, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5CVWLCWVWR5KLFWC53AUDWVU2OZANCNFSM6AAAAAAUQPLZV4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Matthew J. Holman, PhD Senior Astrophysicist Center for Astrophysics | Harvard & Smithsonian 60 Garden Street, MS #51 Cambridge, MA 02138 (617) 496-7775

hannorein commented 1 year ago

Would that be one global parameter or one parameter per particle?

matthewholman commented 1 year ago

It's per particle, particularly if we are fitting for those parameters. Since particle_params is already an array of doubles, I think we can just use that. I deliberately left that flexible.

On Fri, Feb 3, 2023 at 12:30 PM Hanno Rein @.***> wrote:

Would that be one global parameter or one parameter per particle?

— Reply to this email directly, view it on GitHub https://github.com/matthewholman/assist/issues/46#issuecomment-1416182588, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5CVWK4HTOQOGOO4DUVHJDWVU6FFANCNFSM6AAAAAAUQPLZV4 . You are receiving this because you commented.Message ID: @.***>

-- Matthew J. Holman, PhD Senior Astrophysicist Center for Astrophysics | Harvard & Smithsonian 60 Garden Street, MS #51 Cambridge, MA 02138 (617) 496-7775

hannorein commented 1 year ago

Got it!

On Fri, Feb 3, 2023 at 12:59 PM matthewholman @.***> wrote:

It's per particle, particularly if we are fitting for those parameters. Since particle_params is already an array of doubles, I think we can just use that. I deliberately left that flexible.

On Fri, Feb 3, 2023 at 12:30 PM Hanno Rein @.***> wrote:

Would that be one global parameter or one parameter per particle?

— Reply to this email directly, view it on GitHub < https://github.com/matthewholman/assist/issues/46#issuecomment-1416182588 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA5CVWK4HTOQOGOO4DUVHJDWVU6FFANCNFSM6AAAAAAUQPLZV4

. You are receiving this because you commented.Message ID: @.***>

-- Matthew J. Holman, PhD Senior Astrophysicist Center for Astrophysics | Harvard & Smithsonian 60 Garden Street, MS #51 Cambridge, MA 02138 (617) 496-7775

— Reply to this email directly, view it on GitHub https://github.com/matthewholman/assist/issues/46#issuecomment-1416213329, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAANBABWY3SJYI6OQFG5YQLWVVBO7ANCNFSM6AAAAAAUQPLZV4 . You are receiving this because you authored the thread.Message ID: @.***>

hannorein commented 1 year ago

Could you share the file apophis_dump.dat? Otherwise I can't run the test. Thanks!