matthewholman / assist

ASSIST is a software package for ephemeris-quality integrations of test particles.
https://assist.readthedocs.io/
GNU General Public License v3.0
24 stars 10 forks source link

cd assist/examples/plain_interface make does not exist #88

Closed RichardGFrench closed 1 year ago

RichardGFrench commented 1 year ago

I tried to install the C version of ASSIST and I get the following errors:

https://github.com/matthewholman/assist/blob/main/README.md

Next, go to one of the example directories and compile the problem file. This will also trigger the installation of the REBOUND and ASSIST shared libraries.

cd assist/examples/plain_interface make

The directory assist/examples/plain_interface does not exist. Instead, I find: /Volumes/dione_raid2/Research/ASSIST/assist/examples

asteroid/ ephemeris/ interpolation/

Then, when I cd to ephemeris I get the following errors:

cd ephemeris/ ls Makefile problem.c make Makefile:14: ../../..//src/Makefile.defs: No such file or directory make: *** No rule to make target `../../..//src/Makefile.defs'. Stop.

hannorein commented 1 year ago

Thanks for pointing out the wrong directory name. We need to update the readme file.

Regarding the second error. It looks like there is an issue with finding REBOUND. I'll push a change which should fix this. But I'm not entirely sure - it depends on where you have downloaded the two packages relative to each other. If nothing else works, try downloading ASSIST and REBOUND in the same directory, e.g.

/Volumes/dione_raid2/Research/ASSIST/assist /Volumes/dione_raid2/Research/ASSIST/rebound

RichardGFrench commented 1 year ago

My current directory tree looks like this - do you see a problem with this?

1700 @.***> tree -d -L 2 ASSIST ASSIST ├── assist │ ├── assist │ ├── data │ ├── dev_tools │ ├── docs │ ├── examples │ ├── jupyter_examples │ ├── src │ └── unit_tests ├── data ├── rebound │ ├── docs │ ├── examples │ ├── ipython_examples │ ├── legacy │ ├── others │ ├── python_examples │ ├── rebound │ └── src └── venv ├── bin ├── include └── lib

On Mon, Aug 7, 2023 at 11:01 AM Hanno Rein @.***> wrote:

Thanks for pointing out the wrong directory name. We need to update the readme file.

Regarding the second error. It looks like there is an issue with finding REBOUND. I'll push a change which should fix this. But I'm not entirely sure - it depends on where you have downloaded the two packages relative to each other. If nothing else works, try downloading ASSIST and REBOUND in the same directory, e.g.

/Volumes/dione_raid2/Research/ASSIST/assist /Volumes/dione_raid2/Research/ASSIST/rebound

— Reply to this email directly, view it on GitHub https://github.com/matthewholman/assist/issues/88#issuecomment-1668040551, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPTRBQLK6W3ZWB3LP7SDOTXUD7NTANCNFSM6AAAAAA3F6YDKM . You are receiving this because you authored the thread.Message ID: @.***>

--

Richard G. French

McDowell and Whiting Professor of Astrophysics, Emeritus

Wellesley College

Wellesley, MA 02481-8203

hannorein commented 1 year ago

If that how it looks like then the error message doesn't quite make sense. I don't know why. You can try setting the REB_DIR environment variable directly. It should point to the main REBOUND directory. In your case /(fullpath)/ASSIST/assist/rebound

RichardGFrench commented 1 year ago

Matt, My problem was obscure - I happened to have an old separate rebound/ directory parallel to the ASSIST directory, which confused the Makefile line

ifneq ($(wildcard ../../../../rebound/.*),) # Check for ASSIST being inside REBOUND directory

I renamed that directory and now everything seems to be working properly.

Dick French

On Tue, Aug 8, 2023 at 1:06 PM matthewholman @.***> wrote:

Closed #88 https://github.com/matthewholman/assist/issues/88 as completed via 4cb349b https://github.com/matthewholman/assist/commit/4cb349b57e96d1b14d9d4771443c015ee5d6f24f .

— Reply to this email directly, view it on GitHub https://github.com/matthewholman/assist/issues/88#event-10038081451, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPTRBTEQAEV6UD6MMKHXOTXUJWXTANCNFSM6AAAAAA3F6YDKM . You are receiving this because you authored the thread.Message ID: @.***>

--

Richard G. French

McDowell and Whiting Professor of Astrophysics, Emeritus

Wellesley College

Wellesley, MA 02481-8203

hannorein commented 1 year ago

Glad you were able to resolve the issue!

matthewholman commented 1 year ago

I'm delighted that you are looking into ASSIST, Dick. Hope all is well!