search

matthewwithanm / python-markdownify

Convert HTML to Markdown
MIT License
1.17k stars 140 forks source link

Headers are not handled well when combined with details/summary tags #129

Closed alexei-osipov closed 6 days ago

alexei-osipov commented 6 months ago

h3 results in badly formatted output when combined with details/summary tags

This code

from bs4 import BeautifulSoup
from markdownify import MarkdownConverter

sample = """
<details><summary>Some question text</summary><div><h3>Answer</h3> Answer text</div></details>
"""

soup = BeautifulSoup(sample, 'html.parser')
result = MarkdownConverter().convert_soup(soup)
print(result)

Actual result (on 0.12.1):

Some question text### Answer

 Answer text

Expected result:

Some question text

### Answer

Answer text
jsm28 commented 6 months ago

PR #120 should help here, it fixes various cases of block tags not being properly separated from adjacent content, including headers.

AlexVonB commented 6 days ago

This was fixed with #120 , thank you for reporting!