matthiasbock / BooleSim

Systems biology tool: Boolean network simulator
http://matthiasbock.github.io/BooleSim
11 stars 6 forks source link

Booleannet Export errors #28

Closed TillS closed 11 years ago

TillS commented 11 years ago

When exporting the network to booleannet format, the network is deeply changed. The problem appears to be a missing space when translating "!" into "not" when there are no parentheses (this time the parentheses are translated correctly from BoolNet to booleannet) but for instance !pluri_exo_meth or !pluri_exo_het_chrom becomes notpluri_exo_meth or notpluri_exo_het_chrom thus creating 2 new species. In python Booleannet, you have to introduce a space after the not!

chaitan3 commented 11 years ago

@TillS, are you using the latest code? please do a git pull and retest, I had fixed this issue last week.

TillS commented 11 years ago

Weird...I just pulled it half an hour ago or so and the error was there. Now I pulled it again and it works. Maybe I forgot to update the browser or so. Cool! Just one minor thing: There is still some misplaced "falses" which give problems when exporting the network to booleannet, re-importing it and clicking on "rules" tab and back on "network" view which then shows the "false" node again. You think, this can still be corrected?

chaitan3 commented 11 years ago

Should be fixed now. Damn, too many formats, code is getting a bit messy :P.

TillS commented 11 years ago

Just pulled it and tried several times. Unfortunately it doesn't work for me yet. When importing the .ginml demo file for the cell cycle, it still shows 2 wrong falses in the rule tab, which make trouble...

chaitan3 commented 11 years ago

The wrong false's are a bit difficult to avoid in the ginml import because of the complicated nature of the rules, they won't show up in the network view though. After exporting the file to python booleannet and importing it back into the simulator, the booleannet file simulates properly and there are no 'false' nodes.