matthijskooijman / arduino-lmic

:warning: This library is deprecated, see the README for alternatives.
707 stars 650 forks source link

Expose the radio.c functions in the LMIC API? #17

Open torntrousers opened 8 years ago

torntrousers commented 8 years ago

What do you think about exposing the constants and functions defined in radio.c as part of the LMIC API, even just a via a radio.h would do?

I'd like to be able to use the radio.c functions in my own code, for example, like in @tftelkamp's gateway but it would be much nicer not to have to duplicate all the LMIC radio.c and hal code.

matthijskooijman commented 8 years ago

What would be needed for this? I think functions would need the static keyword removed, right?

In general, I would like to minimize the changes to the actual LMIC source code, to make upgrades less painful later on (though I'm not sure how much LMIC is still developed upstream, the development is fairly opaque).