search

mattkjames7 / PyGeopack

Wrapper for geopack-08 used for the Tsyganenko magnetic field models
GNU General Public License v3.0
11 stars 2 forks source link

Add WithinMPOnly parameter to ModelField #13

Closed ddasilva closed 2 years ago

ddasilva commented 2 years ago

This merge request is in response to discussion in issue #12. It removes the default behaviour of returning NaN's outside the MP, with the old behaviour still attainable by setting a new keyword arg WithinMPOnly=True.

I tried to respect convention as much as possible in this merge request, with respect to argument ordering and general style. Let me know if I fell short somewhere.

Best, Daniel

mattkjames7 commented 2 years ago

Looks good to me, thanks for this!