Closed GoogleCodeExporter closed 9 years ago
Can you tell what is breaking it?
Right now, I simply pull out exactly what the .xml file has, and supply it (the xml
file repeats a bunch of tags). I'd rather keep the entire contents of that
file if I
can...
I can easily remove tags, but I'd rather keep them if they don't break stuff.
I'll look into removing the duplicates (the easy way is sort|uniq, but it will mess
up the actor orders).
Original comment by yoav.yer...@gmail.com
on 16 Dec 2008 at 5:51
Sorry, one more thing:
remove - episodeTitle
change - title to the episode name rather than the show name
episodeNumber - should also be used. It just happened that the example I used
did not have one.
Original comment by smacdiarmid
on 16 Dec 2008 at 5:54
Multiple things are breaking it.
ColorMode: is using an incorrect value
should be:
x1 = B & W
x2 = Color and B & W
x3 = Colorized
x4 = Color Series
Similar problem with Rating
Can't have empty showBits field.
It seems to me it would be easier to remove the fields than have to set them
with the proper values
Original comment by smacdiarmid
on 16 Dec 2008 at 5:57
I am sure this is an absolute nightmare. But I would be happy to help out in
any way I can. Any ideas?
Original comment by smacdiarmid
on 16 Dec 2008 at 5:58
whoa ok.. Dropping ColorMode and showBits (I doubt anyone cares anyways).
changing title to episde name is something I'd rather avoid doing, because I'm
pulling it right out of the XML... are you sure it's set incorrectly?
And as for helping out: The code that converts the xml file from the tivo to a
text
file for pytivo is just a simple xslt parser. Are you familiar with xslt?
Here's
the current version of the script:
http://code.google.com/p/itivo/source/browse/trunk/pytivo_txt.xslt
Original comment by yoav.yer...@gmail.com
on 16 Dec 2008 at 6:43
episodeTitle defiantly needs to be removed. It causes a strange error that
makes the episodeNumber appear
in the episode title field on TiVo (e.g. "The One Where They Turn Thirty"
becomes "123 The One Where They
Turn Thirty"). This field is also redundant and totally unnecessary (according
to the pyTiVo website) when the
title field is used correctly. Which brings me to the next required change...
The title field definitely needs to be changed. It is just flat wrong.
Currently the title field displays the show
name rather than the episode name. If you check out the pyTiVo metadata
section, this is not correct. The
title field is supposed to have the episode name.
Unless you figure out how to make the Rating field input the correct values
(which would appear to be
difficult, see below) then that field should be removed as well:
x0 = No Rating
x1 = TV-Y7
x2 = TV-Y
x3 = TV-G
x4 = TV-PG
x5 = TV-14
x6 = TV-MA
x7 = TV-NR
As for xslt I am not familiar with it, but I will take a look and see if I can
figure it out. In the mean time if you
have a chance to make the changes above, I think that may just about solve the
problems (I am downloading
a show now to make sure everything else is okay).
Original comment by smacdiarmid
on 16 Dec 2008 at 3:03
Oh, I see you already removed rating.
So, if you make the other two changes I just mentioned above, everything should
be working correctly. Please
make those changes and then I will do a final test to make sure the .txt file
tagging is finished for good :)
Original comment by smacdiarmid
on 16 Dec 2008 at 3:39
Odd Question:
What is supposed to happen if you download a movie instead of a TV show?
Original comment by yoav.yer...@gmail.com
on 16 Dec 2008 at 5:24
I don't know for sure, I have never done it before. But my guess is that the
movie name will fill in the title field.
The isEpisode field will be false. Many of the other TV Show related fields
will be blank (which may or may not
cause a problem).
I will try to find a movie to record when I get home this evening and try it
out. In the meantime lets get TV Show
tagging fixed and checked off the list.
Original comment by smacdiarmid
on 16 Dec 2008 at 5:30
Erm, I think you're missing my point :)
the same .xmltotxt is being done for movies and tv shows as inputs. I figured by
keeping the tags as tivo provides them I'd be doing the right thing for
everything..
you're asking me to hack the values around (clearly to make it work for tv series)..
and I'm wondering what the effect will be on movies -- which are also
downloaded...
(i.e. removing episodeTitle entirely is certainly fine.. I'll do it right now..
but removing "title" seems like it might cause issues).
Original comment by yoav.yer...@gmail.com
on 16 Dec 2008 at 5:35
Ok, just removed episodeTitle, and actually fixed Xrating to do the right thing
(inserted a 0 before the actual number).
I'm kind of stuck on the <title> tag. I wonder why pyTivo uses a different meaning
that the tivo does for it. I'll go see what happens when it's a movie. I can
easily
make episodeTitle tags print both episodeTitle and title variables, and then
ignore
<title> tags... except I wonder if that will break movies.
guess I'll go check that right now...
Original comment by yoav.yer...@gmail.com
on 16 Dec 2008 at 5:46
Yes, I don't understand that either. Because my understanding is that pyTiVo
is simply using fields that TiVo
understands. And according to them the fields are interchangeable (which I
would read to mean, using title
would work for a movie, or a TV Show).
But try it out and let me know.
Original comment by smacdiarmid
on 16 Dec 2008 at 6:10
Oh, by the way. The problem with using both the episodeTitle and title
variables, even if they are the same
value, is that for whatever reason, it cause the episode number bug that I
mentioned above.
Original comment by smacdiarmid
on 16 Dec 2008 at 6:13
Hmm Ok, I just played around, and here's what I'm seeing:
If I set title as it is in the XML file (the show title), then in the list of
available shows, it shows 'show title', with episode name 'show title' (and
correct
description). This is wrong
If i set title to episode name as suggested, the list of shows show up as 'episode
title' instead of showname (although when selecting it, it shows up as
showname/episode name). This is also incorrect (it should be displaying the
name of
the show in the now playing list).
So it looks like what's going on is that pytivo is mis-using those values...
(neither way is correct.. it should be displaying 'showname' on the now playing
list, and then showname/episodetitle when info is pulled up).
Let me see what I can find out from the authors.. This might be a simple change to
pytivo...
Original comment by yoav.yer...@gmail.com
on 16 Dec 2008 at 6:22
Oh and as for movies. There is no episodeTitle tag to get an episode name
from.
Title is correctly set to the movie title
(oddly enough, movies still show up with isEpisode=true)
Original comment by yoav.yer...@gmail.com
on 16 Dec 2008 at 6:23
I think you already have the solution:
"If i set title to episode name as suggested, the list of shows show up as
'episode
title' instead of showname (although when selecting it, it shows up as
showname/episode name). This is also incorrect (it should be displaying the
name of
the show in the now playing list)."
On TiVoGoBack all of my videos are listed with the episode title (and this has
always been the case). I simply
put them in folders by Show Name (which then shows up in TiVo Goback). When
you download the show to
TiVo, the list properly shows the show name and all the correct information.
Original comment by smacdiarmid
on 16 Dec 2008 at 6:33
Well, ermm.. that's not how it should be :)
Anyways, yeah it looks like it was a known bug with pytivo-wgw (when both episode
number and episode title were available, he made the episodeTitle into
<episodenum>
<episodeTitle>
There was a patch to fix this, and voila, when I applied that, using a correct
<title>, <episodeTitle>, <showName> worked right.. so I can use the .tivo xml
as-is
without having to break it up. (good news, but it does mean people will need to
update to the new pytivo release for the metadata tagging to work.. but I
think
that's the right solution...
So yay.
The other tags *should* work correctly now too.. yay.. (that is, in the next beta
release).. I'll push out beta builds later today.. (whew.. thanks for catching
all
these.. yikes)
Original comment by yoav.yer...@gmail.com
on 16 Dec 2008 at 6:56
No problem. Happy to help. I look forward to testing what is hopefully the
final product when I get home today
:)
Original comment by smacdiarmid
on 16 Dec 2008 at 7:10
Ok, ermm, just uploaded a 1.1b1 build of pyTivoX, and a 1.7b6 build of iTiVo.
When you get the chance, can you download both and tell me if the new taggin works
for you?
(pyTivoX will mess up its launch as daemon settings.. so unselect and re-select
that if you care).
Original comment by yoav.yer...@gmail.com
on 16 Dec 2008 at 7:12
[deleted comment]
I am downloading the new versions now. I will test them out this evening. By
the way, auto update isn't working
for pyTivoX, at least not for this beta.
Original comment by smacdiarmid
on 16 Dec 2008 at 9:32
I just downloaded a show. The tagging isn't working properly :( I am not sure
what is causing the error but it is
defaulting to the minimum show information.
I will do some more experimentation, but so far I can't figure it out.
Any ideas?
Original comment by smacdiarmid
on 17 Dec 2008 at 1:08
minimum information via pytivo? or minimum information in the .txt file?
Original comment by yoav.yer...@gmail.com
on 17 Dec 2008 at 1:48
(for what it's worth, I just downloaded a movie, downloaded a tv show, and
downloaded
a file I uploaded via pytivo.. and they are all "working").
Original comment by yoav.yer...@gmail.com
on 17 Dec 2008 at 2:21
The .txt file contains all the information. But on the TiVo it only displays
show name, title, and description,
which is the original problem that started this thread.
Are you sure yours is working? On your TV Show you downloaded you can see
episode number, year, original air
date, etc.?
Original comment by smacdiarmid
on 17 Dec 2008 at 4:01
I definitely saw rating, name, title, description.. I don't remember year or
original
air date specifically.. I'll need to go look again..
Original comment by yoav.yer...@gmail.com
on 17 Dec 2008 at 5:54
Ok, I know you love this :)
Can you get both the new iTiVo and the new pyTivoX and try again?
(the new iTiVo to fix some of the metadata generation.. the rating and genre tags
were broken, the new pytivoX for actually reading the metadata right).
Original comment by yoav.yer...@gmail.com
on 17 Dec 2008 at 8:45
I just tried it out on a TV Show this morning, and.... IT WORKS!
All the data appears to display correctly.
I will test it more thoroughly this evening, but I think you did it!
Original comment by smacdiarmid
on 17 Dec 2008 at 3:39
Original comment by yoav.yer...@gmail.com
on 22 Dec 2008 at 2:32
Original issue reported on code.google.com by
smacdiarmid
on 16 Dec 2008 at 5:18