Do not dispose streams that should not be disposed

mattosaurus / PgpCore

.NET Core class library for using PGP

MIT License

245 stars 98 forks source link

Closed 0xced closed 3 years ago

0xced commented 3 years ago

inputFileStream instances are already disposed because they are inside a using block.
inputStream should not be disposed because it's the caller responsibility to dispose the input stream.
secretOut and publicOut should not be disposed , only the ArmoredOutputStream wrapper should be disposed.

mattosaurus commented 3 years ago

Thanks for this, I'll take a look over it in the next couple of days.

0xced commented 3 years ago

Great!

I'm currently using a stream wrapper that do not dispose the wrapped stream in order to workaround the exception I'm getting:

System.ObjectDisposedException Cannot access a closed file.

mattosaurus commented 3 years ago

I've just published this in v5.4.0