GetPgpInspectBaseResult failed with null object reference

[elim-mt]

Calling the InspectAsync method failed inside the method:

private PgpInspectBaseResult GetPgpInspectBaseResult(Stream inputStream) at line 103 (PGPInspectSync.cs) privateKey = EncryptionKeys.FindSecretKey(publicKeyEncryptedData.KeyId);

With the EncryptionKeys being null and failing when attempting to execute the FindSecretKey method.

[mattosaurus]

Hi @elim-mt, do you have an example of the code you're using to setup and call the InspectAsync method?

[elim-mt]

Yes, I have created an example to show case this issue. Please kindly find it in the attachment. PGPCoreInspectExample.zip

Thank you

[elim-mt]

hi @mattosaurus , would you be able to kindly shed some light to this issue? Thanks

[mattosaurus]

Hi, apologies I'm on holiday at the moment but I'll take a look next week.

[mattosaurus]

Hi, the issue is you need to provide the relevant keys to inspect the message.

        public static async Task<bool> IsPgpEncryptedAndSignedAsync(string content)
        {

            if (string.IsNullOrEmpty(content)) throw new ArgumentNullException(nameof(content));

            EncryptionKeys encryptionKeys = new EncryptionKeys(new FileInfo(senderPublicKeyfilePath), new FileInfo(receiverPrivateKeyFilePath), receiverPrivateSecrets);
            PGP pgp = new PGP(encryptionKeys);

            PgpInspectBaseResult? result;
            result = await pgp.InspectAsync(content); 

            if (result != null)
                return (result.IsEncrypted && result.IsSigned);

            return false;

        }

[elim-mt]

Thank you so much for explaining this. Amending my code with your suggestion works. However, I feel that the code inside PGPInspectSync can be a little safer rather than just assuming that the EncryptionKeys object has been set.

Furthermore, it would appear that the InspectAsync function works fantastic if we are testing if a payload is encrypted and/or signed with known keys. However, if one simply wants to know if they payload has been encrypted or signed without passing any encryption keys for inspection, then this wouldn't work so well.

In any case, thank you.

[mattosaurus]

Yes, I think when I was adding these methods I just wanted to make them as complete as possible. However I agree there's scope for updating them to only check properties with the provided keys (if any).