search

mattpitkin / psrqpy

A python module to query the ATNF pulsar catalogue
MIT License
41 stars 26 forks source link

Maybe add more features to the condition parameter in QueryATNF? #68

Open astrogewgaw opened 4 years ago

astrogewgaw commented 4 years ago

You have already added support for querying the catalogue using logical conditions, but some things are still not supported, such as the RANGE function, or specifying a range of RA/DEC using the HMS/DMS functions or h/d keywords. It would be nice if this feature was expanded to include these functions, along with the SURVEY, DISCOVERY functions. All the functions I just mentioned are (as you probably know) described here, in section 2.3.

mattpitkin commented 4 years ago

Thanks for the suggestion. It should be pretty easy to implement the SURVEY and DISCOVERY functions, so I will try and add them in soon. It will take a bit more effort to add range properly and I don't really have the time at the moment. I am more than happy to take pull requests for any code changes though!

mattpitkin commented 4 years ago

I've added the survey and discovery functions. I'll make a new release that's available via pip and conda when I've merged another issue about the references.

renato10nr commented 3 years ago

I would like to learn how to use the astroquery vizier to download two catalogs, a pulsar catalog and a Fast Radio Bursts catalog. Would you help me?

mattpitkin commented 3 years ago

Hi @renato10nr, I'm afraid I have no experience downloading VizieR catalogs via astroquery, so can't be of much help. From the looks of things VizieR's pulsar catalogs are those extracted from individual papers, whereas this software (psrqpy) gets the catalog of all pulsars as held in the ATNF Pulsar Catalog.