mattstein / alfred-tower-bookmarks-workflow

Launch Tower bookmarks from Alfred.
MIT License
2 stars 0 forks source link

PHP 8.4 compatibility #1

Open mcaskill opened 2 months ago

mcaskill commented 2 months ago

While doing some application testing in PHP 8.4-dev, I launched Alfred to use your workflow and the following deprecation notices were logged:

PHP Deprecated:  Alfred\Workflows\Workflow::env(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in ~/Library/Application Support/Alfred/Alfred.alfredpreferences/workflows/user.workflow.***/vendor/joetannenbaum/alfred-workflow/src/Workflow.php on line 98
PHP Deprecated:  CFPropertyList\CFPropertyList::add(): Implicitly marking parameter $value as nullable is deprecated, the explicit nullable type must be used instead in ~/Library/Application Support/Alfred/Alfred.alfredpreferences/workflows/user.workflow.***/vendor/rodneyrehm/plist/src/CFPropertyList/CFPropertyList.php on line 526
PHP Deprecated:  CFPropertyList\CFDictionary::add(): Implicitly marking parameter $value as nullable is deprecated, the explicit nullable type must be used instead in ~/Library/Application Support/Alfred/Alfred.alfredpreferences/workflows/user.workflow.***/vendor/rodneyrehm/plist/src/CFPropertyList/CFDictionary.php on line 89
PHP Deprecated:  CFPropertyList\CFArray::add(): Implicitly marking parameter $value as nullable is deprecated, the explicit nullable type must be used instead in ~/Library/Application Support/Alfred/Alfred.alfredpreferences/workflows/user.workflow.***/vendor/rodneyrehm/plist/src/CFPropertyList/CFArray.php on line 87

I've submitted issues to your dependencies:

mattstein commented 2 months ago

Hey, thanks for doing that @mcaskill! ❤️

mattstein commented 1 month ago

Looks like the maintainer of CFPropertyList just archived the project, so I’ll need to figure out what to do with that.

mcaskill commented 1 month ago

Looks like it will have to be forked again 😕.

According to the commit history, Teclib took over the package from Rodney Rehm ~12 years ago 😯.