search

mattvb91 / Subterminal

Android B.A.S.E jumping logbook app
https://subterminal.eu
3 stars 0 forks source link

Implemented Material Design Changes #91

Closed stevenberdak closed 7 years ago

stevenberdak commented 7 years ago

I went ahead and made some changed to the layout code. I believe this is what you meant. Simply adding some uniformity to the color res values. I didn't want to mess with things too much but I also made a few other minor changes.

All of the layout values can now be changed easily by simply adjusting the base theme attributes in the colors.xml. This could obviously be optimized a lot further but I didn't want to take too much liberty in doing anything outside the scope of the original issue request.

Thank you 👍

Disclaimer: There is a type in the word "border" in my commit comment...

mattvb91 commented 7 years ago

Awesome stuff that looks great! Love how easy it is to check out different material themes now. Will include this in the 1.3.2 release & comment when its tagged . Ive also updated the repo readme to link your github in contributors.

Im away for the weekend but next week I will open & label what I think are fairly easy theme changes if your interested in grabbing some.

Just out of interest did you have any issues getting the app to run on your local dev machine? I think I need to update some the keys file to prevent crashes under dev build variant.

stevenberdak commented 7 years ago

I did, I was going to look over some other issues however I am getting a couple run time errors when I try to access any fragment that contains ads. I am getting an invalid API key error as well as a Ad resource not found or something similar to that. If there was a simple workaround I could try that however I havent had enough time to figure out what parts of the code specifically i need to disable to bypass that. I might look into ot more later. Specifically id like to fix the count errors next.

On Nov 16, 2017 9:40 AM, "Matthias von Bargen" notifications@github.com wrote:

Awesome stuff that looks great! Love how easy it is to check out different material themes now. Will include this in the 1.3.2 release & comment when its tagged . Ive also updated the repo readme to link your github in contributors.

Im away for the weekend but next week I will open & label what I think are fairly easy theme changes if your interested in grabbing some.

Just out of interest did you have any issues getting the app to run on your local dev machine? I think I need to update some the keys file to prevent crashes under dev build variant.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mattvb91/Subterminal/pull/91#issuecomment-345000873, or mute the thread https://github.com/notifications/unsubscribe-auth/AWOY4mb5e_6glcpOP4wlWP-xGjCyL_dgks5s3HOagaJpZM4Qf6mE .