search

matty-r / urChat

urChat is a Java based IRC Client designed around simplicity and minimal resource impact on your system.
Apache License 2.0
16 stars 3 forks source link

Add initial GitHub Actions build for Maven #77

Closed chabala closed 11 months ago

chabala commented 11 months ago

Runs your new Maven build, on every PR, and every push to main. JaCoCo report included, and working.

matty-r commented 11 months ago

Cool, thanks for that. I'll take a look soon to get my head around it. I've not setup github actions before.

chabala commented 11 months ago

You can check out my draft PR in my fork where I was testing it out: https://github.com/chabala/urChat/pull/1

matty-r commented 11 months ago

Are you able to add Main-Class: urChatBasic.frontend.DriverGUI to the MANIFEST.MF that is in the .jar that is produced by this? At the moment it's not possible to run the .jar file as it throws an error "no main manifest attribute, in urchat-0.4.0.jar".

chabala commented 11 months ago

I can, though that's not really in scope for this PR. This is more about getting basic CI set up, rather than fine tuning your Maven build.

matty-r commented 11 months ago

I can, though that's not really in scope for this PR. This is more about getting basic CI set up, rather than fine tuning your Maven build.

Understood, but i'd rather have it at least usable in it's basic state than not. Appreciate it!