search

mattydebie / bitwarden-rofi

Wrapper for Bitwarden https://github.com/bitwarden/cli and Rofi
GNU General Public License v3.0
346 stars 56 forks source link

pass ROFI_OPTIONS in ask_password #53

Closed ickerwx closed 2 years ago

ickerwx commented 4 years ago

I was playing around with several rofi theming options and noticed that my options were not applied when bwmenu was asking for the master passwort. With my patch the options will be passed to rofi when asking for the passwort.

mattydebie commented 4 years ago

Nice catch! 

-------- Original message --------From: ickerwx notifications@github.com Date: 7/15/20 14:45 (GMT+01:00) To: mattydebie/bitwarden-rofi bitwarden-rofi@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [mattydebie/bitwarden-rofi] pass ROFI_OPTIONS in ask_password (#53) I was playing around with several rofi theming options and noticed that my options were not applied when bwmenu was asking for the master passwort. With my patch the options will be passed to rofi when asking for the passwort.

You can view, comment on, or merge this pull request online at:   https://github.com/mattydebie/bitwarden-rofi/pull/53

Commit Summary

pass ROFI_OPTIONS in ask_password

File Changes

M
bwmenu
(2)

Patch Links:

https://github.com/mattydebie/bitwarden-rofi/pull/53.patch https://github.com/mattydebie/bitwarden-rofi/pull/53.diff

—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.

aacebedo commented 3 years ago

Found the same ! Can you merge the branch please ? I would like to get the fix :)

AlecsFerra commented 3 years ago

The same thing should be done for the error prompt

mattydebie commented 2 years ago

Added to master