matus-chochlik / ctcache

Cache for clang-tidy static analysis results
Boost Software License 1.0
84 stars 30 forks source link

Adjust clang-tidy-cache-server for modern flask #19

Closed dsilakov closed 1 year ago

dsilakov commented 1 year ago

Parameters for send_from_director that were depreated in Flask 2.0.0 were completely dropped in 2.2.0: https://flask.palletsprojects.com/en/2.3.x/changes/#version-2-2-0

So 'filename' is not a legit name anymore.

I guess it was left in https://github.com/matus-chochlik/ctcache/commit/3ff698f7f87055042cace71321ffc3042337bae3 to be compatible with both modern and old flask. Looks like this is not that easy these days, but maybe now it is ok to require flask >= 2.0.0 and drop legacy parameter name.

And in addition, we can specify download_name