matus-chochlik
commented
10 months ago Hi, would you mind splitting this in at least 2 or maybe more separate PRs? Also I have several concerns:
-
It changes the default storage location. I don;t mind supporting other OSes, but the decision to store the cache data in temporary directory was done deliberately. The intention was that if people use ctcache locally in day-to-day development keeping the data in temp automates clearing of the cache data in reasonable intervals. If users want, they can change the storage location. I'd like to keep this, I know some users that rely on this behavior.
-
I don't mind adding the functionality to serialize some additional information, but I'd like this to be optional (again enabled by an env var) the original intention was for ctcache to be lean and not store too much data. I can see use cases for storing additional stuff, but again I know there are users that rely on the fact that the default setup doesn't clutter the disk (or tmpfs) in the default mode.
solarispika
I have tested it with local/server/redis caches, and find no obvious error. Other caches are also modified correspondingly, but I didn't test them due to lacking of environments.
Any suggestion/comment is welcome!