Fix animation glitch on iOS 17

maustinstar / liquid

Create a playful backsplash in SwiftUI.

MIT License

817 stars 30 forks source link

Fix animation glitch on iOS 17 #12

Open borsosbe opened 3 months ago

borsosbe commented 3 months ago

Remove combine
For iOS 17 or later use the new animation callback
Below that use Task with a delay based on Liquid period
Tested on physical devices running iOS 16, 17

mplawley commented 1 month ago

I encountered the same animation glitch with the repo's README's example Liquid code and pointed my Liquid package dependency to commit dbd0a02b00de9a4d0171cf63b4998991d13b8502.

I tested the fix on this PR on the following devices:

iPhone 15 simulator running iOS 16.1.
iPhone 15 simulator running iOS 17.2.
iPhone 16 Pro (real device) running iOS 18.0.1

It worked for all three.