search

mautic / Community-Portal

Mautic's community governance portal, based on Decidim.
https://community.mautic.org
GNU Affero General Public License v3.0
3 stars 5 forks source link

fix: session store from issue #57 #64

Closed rsdeus closed 9 months ago

rsdeus commented 10 months ago

This PR fixes the issue #57 by installing the activerecord_session_store - https://github.com/rails/activerecord-session_store.

froger commented 10 months ago

Hi @rsdeus I can't see any migrations files in this PR. I was expecting some after rails generate active_record:session_migration execution locally. Can you check this?

rsdeus commented 10 months ago

Hi @rsdeus I can't see any migrations files in this PR. I was expecting some after rails generate active_record:session_migration execution locally. Can you check this?

Sorry @froger , here is the migration file https://github.com/mautic/Community-Portal/compare/main...fix/session_store

froger commented 9 months ago

Thanks for looking into this, could you share how it is possible to test? I guess it's a bit tricky given that it's quite a transient error which isn't affecting everyone.

Hi @RCheesley yes it is not really testable as it is. But I have reviewed and it looks fine to me. I am setting up a testing environment to be sure nothing breaks.