max-christian / homebridge-texecom

A plugin for homebridge (https://github.com/nfarina/homebridge) to integrate Texecom Premier Elite zones into HomeKit
MIT License
27 stars 8 forks source link

Fix SIGTERM after IP connection closed #17

Closed garethflowers closed 4 years ago

garethflowers commented 4 years ago

The IP address and port variables are being lost when the connection close event is fired. This PR ensures the address/port is still populated with the values defined in the config - and prevents a SIGTERM being raised.

Resolves #16

losh11 commented 4 years ago

Can this be merged please @max-christian?

max-christian commented 4 years ago

Sorry, just had a baby and not quite keeping up at the moment. @losh11 have you tested this pull request? If so I'll go ahead and merge without testing further.

losh11 commented 4 years ago

Congrats on the baby! Yep tested.

On Tue, 18 Aug 2020 at 18:08, Max C notifications@github.com wrote:

Sorry, just had a baby and not quite keeping up at the moment. @losh11 https://github.com/losh11 have you tested this pull request? If so I'll go ahead and merge without testing further.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/max-christian/homebridge-texecom/pull/17#issuecomment-675602455, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAT43ORTHV2XP3JFWVGF2ZTSBKYSXANCNFSM4OLV6BNQ .