Improve popup UI - Githubissues

xyaman commented 1 year ago

The UI works fine in most cases, but there are some things I think it can improve user experience as well fix some bugs related. Here are some ideas:

Get rid of the hiragana next to the word and use the pitch accent graph below the word, or put furigana above the word instead.
Set a maximum width and height for the popup, so it doesn't go off-screen and takes up less space (ex. mobile devices). This would require some CSS changes.

If I come up with more ideas, I'll add them here. Let me know what you think, and I could even start working on these changes.

max-kamps commented 1 year ago

Already asked Kou for furigana on words, but unfortunately there is no API to get them yet

max-kamps commented 1 year ago

Definitely :+1: on the popup height and mobile accessibility. All help on mobile support is super appreciated.

max-kamps commented 1 year ago

Starting with version 11.0, popup height is now limited and scrolling is enabled. Not sure how this interacts with mobile currently.

max-kamps / jpd-breader