Closed remixz closed 9 years ago
One note: The app code was moved into a new app
folder to make it easier to create the executable, as otherwise it'd mean copying over each file individually, which would be messy, especially if someone forgot to add the new file to the makefile.
ah crap, just saw this. I was just doing this at the same time https://github.com/maxogden/atom-shell-packager
do you wanna update your makefile to run npm run build
instead?
No worries! Your solution is much cleaner anyway, haha. Will do that.
@remixz also I am not sure it is necessary to move everything into an app
folder. The only downside I see is that if you build the .app twice then the second one would include a copy of the first one, but we can fix that potential edge case by adding --ignore=Monu.app
to the atom-shell-packager step.
I think your Makefile hackery was super cool, but I thought it would be another useful project for the atom-shell community to have an app packaging CLI tool, so I figured I'd bite the bullet and set the project up now. If I hadn't done that at the same time then I'd totally be cool using your Makefile portion
@maxogden Yeah, I just put it all into an app folder for ease of use with a Makefile, so I didn't have to muck around with temp folders. In JS though, much easier! :smile:
I've just updated the PR now (force pushed since there was some ugly history).
@remixz btw long term it would be cool to see you break the release stuff into a standalone release module :) but its probably better if we wait and use it for a while to get a sense of what features we would want in a standalone CLI (e.g. how abstract to make the API, vs how specific to atom apps to make it)
@remixz Just published this with make publish
! https://github.com/maxogden/monu/releases/tag/v1.0.4
Fixes GH-9.
Now releases are super easy! :sparkles: Publishing instructions are in the README.