maxbanton / cwh

Amazon Web Services CloudWatch Logs Handler for Monolog library
MIT License
416 stars 82 forks source link

[BUG] - Declaration of Maxbanton\Cwh\Handler\CloudWatch::write(array $record)... #116

Open tanerincode opened 1 year ago

tanerincode commented 1 year ago

Describe the bug Declaration of Maxbanton\Cwh\Handler\CloudWatch::write(array $record): void must be compatible with Monolog\Handler\AbstractProcessingHandler::write(Monolog\LogRecord $record): void

Please tell about your environment:

maximusblade commented 1 year ago

Yeah I'm having the same issue actually. Same setup too.

markinjapan commented 1 year ago

Same issue here. Seems to be related to the change of function signature of Monolog\Handler\AbstractProcessingHandler::write() in this commit: https://github.com/Seldaek/monolog/blob/22c8b19358e916c52f1d2170d44e172152de7c25/src/Monolog/Handler/AbstractProcessingHandler.php

tanerincode commented 1 year ago

Yes, I saw that. but I'm trying to solve this problem in my local workspace. this seems kind of easy but I haven't worked it out yet.

jelledijkstra97 commented 1 year ago

+1

bassem-shoukry commented 1 year ago

+1

MarioZ2002 commented 1 year ago

+1

rafaellaurindo commented 1 year ago

+1

neninja commented 1 year ago

+1

wattnpapa commented 1 year ago

any update?

tanerincode commented 1 year ago

any update?

I guess no, I don't think he has enough time for this.

stefanrakicfaxi commented 1 year ago

Any news, pretty urgent

tanerincode commented 1 year ago

nope, he is not available, i guess..

maximusblade commented 1 year ago

If someone has the capacity to fork this project and manage it I would happily buy them a regular coffee.

I currently do not have the capacity or know how to manage this.

This is an opportunity for someone to take on a worthwhile project.

markinjapan commented 1 year ago

I'm not sure why the original developer isn't responding, but I'd be happy to take over until he returns.

For now I've forked this project, merged the feature/php-8.1 branch, and created a pre-release v3.0.0-RC1:

https://github.com/phpnexus/cwh/releases/tag/v3.0.0-RC1

So far it works fine for me, so if anyone would like to try it out please add this to your composer.json require section:

"phpnexus/cwh": "^v3.0.0-RC1@dev"

For now this is just a fork and merge, but I do plan to expand on the documentation more too, especially around the AWS IAM permissions.

markinjapan commented 1 year ago

After some testing, I've created a stable release of the feature/php-8.1 branch as v3.0.0:

https://github.com/phpnexus/cwh/releases/tag/v3.0.0

To install, simply run:

composer require phpnexus/cwh
amjeed-ay commented 1 year ago

After some testing, I've created a stable release of the feature/php-8.1 branch as v3.0.0:

https://github.com/phpnexus/cwh/releases/tag/v3.0.0

To install, simply run:

composer require phpnexus/cwh

Great Job, I going to try it hope the above issue has been fixed