maxbanton / cwh

Amazon Web Services CloudWatch Logs Handler for Monolog library
MIT License
417 stars 84 forks source link

Fix: Support for max event size limit #50

Closed amandas-sukionis closed 6 years ago

amandas-sukionis commented 6 years ago
maxbanton commented 6 years ago

Hi @amandas-sukionis. Thanks for your pull request. Could you please explain use cases when you need to put 524256 bytes of log message?

amandas-sukionis commented 6 years ago

Sure, we are relying on a 3rd party XML api to manage user bookings and on the error cases we log the full request/response information. Due to the nature of these requests they are pretty large. This is not a very common case for us, but it still happens. It seemed that it would be easier to implement this on the library level (as it's an AWS limit, similar to batch size) instead of managing log sizes and error handling on our part.

maxbanton commented 6 years ago

Thanks @amandas-sukionis. Merged and new version published https://packagist.org/packages/maxbanton/cwh#v1.1.9