search

maximtrp / scikit-posthocs

Multiple Pairwise Comparisons (Post Hoc) Tests in Python
https://scikit-posthocs.rtfd.io
MIT License
351 stars 40 forks source link

ENH Implement Critical Difference Diagrams #57

Closed pedroilidio closed 1 year ago

pedroilidio commented 1 year ago

I recently made a function to plot Critical Difference diagrams, and from https://github.com/maximtrp/scikit-posthocs/issues/54 it seems it might be appreciated as part of this package.

Closes https://github.com/maximtrp/scikit-posthocs/issues/54.

I'd be glad to hear some opinions on this feature. Here follows a sample image I generated with it:

all_datasets__cdd__TL_average_precision

It currently requires passing the rank values to be plotted alongside the posthoc test results, which could be further integrated in the future as a single step.

maximtrp commented 1 year ago

Thank you very much for this contribution! Looks nice! Could you please write some tests for this functionality and add a corresponding section (several words about it, an example) to the documentation?

pedroilidio commented 1 year ago

Glad you liked it! Thanks for reviewing it.

Could you please write some tests for this functionality and add a corresponding section (several words about it, an example) to the documentation?

I sure can. Will work on that in the next couple weeks.