search

maximvelichko / pyvera

A python library to control devices via the Vera hub
GNU General Public License v2.0
26 stars 30 forks source link

Add ability for HASS to determine when user enters a valid PIN on lock #119

Closed colohan closed 4 years ago

colohan commented 4 years ago

I really wanted Home Assistant to be able to take an action when I unlock my door with a valid PIN. But the pyvera library didn't seem to give me the ability to do that in a clean way (and honestly, the Vera HTTP API makes it crazily complex to detect this event....).

So I created a function which makes this information to Home Assistant. I also added a bunch of comments clarifying what I learned as I read the code. Please let me know if you'd like anything here changed!

pavoni commented 4 years ago

This looks good to me - and thanks for taking the time to add the very useful comments. Any thoughts from elsewhere before I merge?

colohan commented 4 years ago

FYI -- the corresponding PR for Home Assistant (plumbing this through) is here: https://github.com/home-assistant/home-assistant/pull/27043

pavoni commented 4 years ago

Now released as 0.3.6. Thanks for the contribution.

colohan commented 4 years ago

Thanks for making it easy to contribute! ;-)

On Tue, Oct 1, 2019 at 7:36 AM Greg Dowling notifications@github.com wrote:

Now released as 0.3.6. Thanks for the contribution.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pavoni/pyvera/pull/119?email_source=notifications&email_token=AEJ4LULDAVZTSNIW7A5PZL3QMNOAXA5CNFSM4I3J2ALKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEABP2CI#issuecomment-537066761, or mute the thread https://github.com/notifications/unsubscribe-auth/AEJ4LUPHPAIHQC5NC7DEKZ3QMNOAXANCNFSM4I3J2ALA .