Fix seeding for multi-rule systems - Githubissues

maxitg / SetReplace

C++/Wolfram Language package for exploring set and graph rewriting systems

MIT License

216 stars 43 forks source link

Fix seeding for multi-rule systems #653

Closed maxitg closed 3 years ago

maxitg commented 3 years ago

Changes

Resolves #642.
Fixes seeding in multi-rule WolframModel.

Comments

Adding matches for different rules in parallel caused non-determinism, which broke consistency with specified seeds.
In the case of multiple rules, the matches are now added to intermediate storage (similar to EventDeduplication::SameInputSetIsomorphicOutputs), and then sorted before being added to the main storage.

Examples

In[] := Counts @ Table[
  BlockRandom[
    WolframModel[<|"PatternRules" -> {{{1, 2}} -> {}, {{2, 3}} -> {}}|>,
                 {{1, 2}, {2, 3}},
                 <|"MaxEvents" -> 1|>,
                 "EventOrderingFunction" -> "Random"]["FinalState"],
    RandomSeeding -> 123],
  100]
Out[] = <|{{2, 3}} -> 100|>

This change is