maxosprojects / open-dobot

open-dobot - Open Firmware, Driver and SDK for Dobot Arm
MIT License
141 stars 64 forks source link

adds support & api for pump and valve actuators #13

Closed schmurfy closed 8 years ago

schmurfy commented 8 years ago

I am not that clear what are the physical actuators exactly but it works, when you turn both on it grabs things xD

schmurfy commented 8 years ago

It gets a little problematic when trying to actually use it as I just realized, since these are executed immediately instead of being queued it does not work that well ^^

maxosprojects commented 8 years ago

yes, I realized that it is executed asynchronously to the movement commands after having implemented laser control. That requires slightly different command representation in firmware and slightly different handling + make sure that everything still fits in the allowed time frame to not miss to send next byte via SPI to the FPGA. That said, let's still consider merging this (after we decide whether we want two commands or just one for the pump) and improve later. Incremental improvements. FYI, you can still use time.sleep() to delay execution of this command, though it would be horribly inconvenient and a dirty workaround.

Thanks for the code!

schmurfy commented 8 years ago

The ideal would be to have all the commands queued but I haven't looked at your code too deep so I can't comment on this, the problem is that you need to enable the pump at a precise point otherwise there is not much use to it and it will be the same problem with the claw.

maxosprojects commented 8 years ago

There will be no problem with the gripper as it will be a part of movement command that is sent to FPGA. FPGA is in charge of PWM pins on the top board that controls the gripper. The pump will be fixed by extending the command structure in the firmware and being appropriately queued along with the movement commands. Please create a separate issue to fix laser/pump commands (after this PR is merged) and I'll plan it for the upcoming release.

maxosprojects commented 8 years ago

Merged as I got some time to make them queued.

Please create another PR to add description to those commands. Thanks.

maxosprojects commented 8 years ago

Queueing implemented. See #14

schmurfy commented 8 years ago

great :)