search

mazkolain-zz / spotimc

GNU General Public License v3.0
302 stars 42 forks source link

CULyrics = no audio #138

Closed newphreak closed 10 years ago

newphreak commented 10 years ago

It seems that culyrics lookup kills the audiostream. I do not use this add-on, think it was left enabled by some skin i tested earlier. Anyhow, with this enabled, as soon as you go to fullscreen visualisation and culyrics starts to search for lyrics the music stream dies.

newphreak commented 10 years ago

ups, duplicate, didn't look closely enough. #110

mazkolain-zz commented 10 years ago

As suggested on #110, it requires changes on both cu.lrclyrics and Spotimc. The required PR is already merged on the cu.lrclyrics addon, and the next Spotimc release (which should see light soon) will include the fix for this.

Thanks for reporting!

satrich commented 10 years ago

I still have the issue that audio breaks after cu.lrclyrics has searched for lyrics. I am using the Aeon skin in XBMC on Windows 8.1. Using your latest Beta 5.

Anyway, you created a great Add-on. It is very much appreciated.

mazkolain-zz commented 10 years ago

Hi,

As stated above, the required change on the lyrics script is already merged, but the latest release of it does not yet include this patch.

You'll have to try with the usual workaround in the meantime: https://github.com/mazkolain/spotimc/issues/92#issuecomment-15029166

satrich commented 10 years ago

OK. Thanks for your answer. I figured that out myself. But in the changelog it is saying that is is fixed. So, I just thought to mention it here that it is not fixed.

mazkolain-zz commented 10 years ago

Hi @satrich,

Is true that the changelog may be quite misleading on this issue. Perhaps I should update the faq, or even better: Ask the lyrics plugin author if a snapshot release is possible...