search

mazurio / bodyweight-fitness-android

Bodyweight Fitness (Android)
Other
318 stars 104 forks source link

Split side planks #56

Closed annawoodard closed 7 years ago

annawoodard commented 7 years ago

This PR splits side planks into separate exercises so that users can track each side independently.

I was unable to build without 1f5108a and 8fe82b3-- let me know if you prefer me to split those out so you can consider them separately.

mazurio commented 7 years ago

Hi @annawoodard,

The first two commits are good. I think those tests are very out of date - they were added a while ago before UI changes. It might be worth changing the video of the second side plank - I was thinking about mirroring the mp4 - what do you think?

annawoodard commented 7 years ago

Great point about the video @mazurio, sorry I missed that! Should be taken care of in 202e9ea:

screen shot 2017-01-06 at 10 04 22 pm

screen shot 2017-01-06 at 10 07 36 pm

annawoodard commented 7 years ago

@mazurio Ah, thanks for pointing that out! Should be fixed in 36cb9ef.

mazurio commented 7 years ago

Thanks @annawoodard