mazurio / bodyweight-fitness-android

Bodyweight Fitness (Android)
Other
317 stars 102 forks source link

Minor tweaks to timed exercise interface #60

Open annawoodard opened 7 years ago

annawoodard commented 7 years ago

Consider a few minor tweaks to the timed exercise interface:

  1. Reset the time automatically after logging I believe that how long users are holding per set is what they are most interested in (after all, that's how the data are logged.)
  2. Replace pause icon with check icon This would be closer to how the rep exercises work, the user will already expect that "check" means "done and log".
  3. Enable time decrements from the top level This one is important for newbies like me that can't hold for a full minute. The user can press pause currently if they don't make the full minute, but it would be preferable to set the amount of time they are shooting to accomplish. In that way they can concentrate on holding the position, rather than anticipating fumbling for the pause button. To keep the screen from getting too busy, this could be accomplished by replacing the reset button (which would be less needed after implementing the first point above) with the "+" button, and the "+" button with a "-" button.
  4. Tweak TimePicker The TimePicker interface that comes up when you click the time is not very useful for short time periods. Preferably it could display a smaller time window.
mazurio commented 7 years ago

Hi @annawoodard - here are my thoughts:

  1. Sometimes when set is set to 3 minutes (e.g. Support/Hold) then doing it for 40 seconds, stopping (resting) and then having 2 minutes 20 seconds left is actually very useful.

  2. I would be keen to leave pause as it is - I have not seen any feedback regarding this and stop/play icons are very popular (make sense with timer). Check icon is great for reps logger now.

  3. '+' button was meant to go away. It was just there to match fitloop website at the beginning. Reset button is actually most useful button there. It's a way to quickly reset the set. There is also a reason why '-' was never added. It was to push the 'user' of the app to accomplish the goal :-).

  4. I agree with this. The idea was to replace android time picker completely with new view that just shows most useful timer options e.g. '30 seconds', '15 seconds', '45 seconds', '1 minute', '2 minutes' etc.

richq commented 7 years ago

Please reconsider not changing to a "most useful" options list for 4, as it would nerf the feature too much. It is fine as it is. The time picker is a common widget for Android and lets you have enough control once you know how to use it.

For a use case: I have my holds set to say 30 seconds, then increment to 32, 33, 35, 37, etc. over the weeks to see gradual improvement without having to mess with pressing pause or anything. My set up time - the couple of seconds it takes to get into a hold - is constant, so any incremented time marks an actual improvement. Having to jump from 30 seconds to say 45 seconds would be too big a leap IMO, and if I bailed early by the time I've paused it I wouldn't really know if I'd done any better than last time or not.

Well, do what you like, it's your app, but I think it's perfect as it is.

mazurio commented 7 years ago

Thanks @richq - this is a great feedback. I think I kind of wrote what I meant wrong, what I was planning for a while is to:

This way we wouldn't kill existing functionality but also add "most common times". I don't think it's a priority thought which is why I haven't done it yet for a really long time :-)