search

mbari-org / vars-annotation

Video Annotation Application for MBARI's Media Management (M3) software stack
https://docs.mbari.org/vars-annotation/
Apache License 2.0
16 stars 6 forks source link

Bulk editor changes do not update observer #79

Closed lindakuhnz closed 6 years ago

lindakuhnz commented 6 years ago

Bulk editor should change the observer to the currently signed in user when making updates to annotations

NancyJS commented 6 years ago

Agreed, this is a critical feature to reinstate into VARS. We always want to track observer and each of their annotations over time. Thanks!

hohonuuli commented 6 years ago

My understanding is that the changes that @lindakuhnz is referring to is that when she changes the group or activity (e.g. changes annotations from transect to descend) the user is not being updated. We had previously had a discussion about this and the consensus was that in those cases the user should not be changed.

For other cases, such as when the bulk editor is used to change the concept, the user is changed.

So please clarify what the correct behavior should be for changing groups and activities.

hohonuuli commented 6 years ago

Relevant code:

  1. UpdateAnnotationsCmd.java
  2. ChangeActivityCmd.java
lindakuhnz commented 6 years ago

Just changed an annotation to 1-gallon paint bucket, but observation doesn't not change. See attached. Yes, confirming no observer change for activity.

untitled
lindakuhnz commented 6 years ago

Meant observer doesn't not change. I changed the annotation via bulk editor.

hohonuuli commented 6 years ago

Found bug. Fixed. See change set above. New release in \Atlas\Tempbox\brian\shore