mbari-org / vars-gridview

VARS GridView is a tool for reviewing and correcting VARS localizations in bulk.
MIT License
2 stars 0 forks source link

Label changes not saved over VPN #75

Open mkbassett opened 9 months ago

mkbassett commented 9 months ago

Over the last couple of weeks Megan and Kris have made changes in Gridview from home while on VPN. It appears that the label changes were not saved, but the "verifier" was updated to our respective names. The attached images show that both Megan and Kris are the verifiers of the highlighted images, but the concept was not changed to "Tomopterid eggcase". We both went in separately and made these changes on different days and neither stuck.

Screenshot 2024-01-30 at 9 18 32 AM Screenshot 2024-01-30 at 9 18 20 AM
kevinsbarnard commented 9 months ago

@mkbassett @kwalz That's strange -- could you please share the log file from the session when you changed the label? Where there any errors that appeared? I just tested changing the label for this exact annotation on the test server (while connected over VPN, though that wouldn't matter to GridView) and all seemed to go ok.

Things to check:

  1. Make sure you're pressing the blue "label" button and not the green "verify"
  2. In settings, ensure you're configured for production VARS:
    • M3 -> Raziel URL: http://m3.shore.mbari.org/config
    • SQL -> Server URL: perseus.shore.mbari.org

Sanity check:

Both observations currently have concept = "Tomopterid eggcase". Was this changed some other way than through GridView?

kevinsbarnard commented 9 months ago

Ah, I think I know what's going on here -- I believe this is the same issue as #72, where there are two bounding boxes (one for the animal, one for the eggcase) tied to the same annotation, so changing the concept applies to both bounding boxes.

As a reference, this was why we originally went with the structure of having the concept be a field within the observation, and the part be a field (the to_concept) within the bounding box association. Under that view, there would be a single annotation (concept = 'Tomopteris'), where one bounding box is for the whole animal (to_concept = 'self') and the other is for the eggcase (to_concept = 'eggcase'):

Tomopteris
    bounding box | self | {...}
    bounding box | eggcase | {...}
kwalz commented 9 months ago

Ah, that's it, Kevin. Thank you for looking into it so quickly for us. This gets me every time with the multiple boxes associated with one line of annotation in VARS.

kevinsbarnard commented 9 months ago

Sure thing! I think it would be good to discuss this at one of the VARS meetings, and even if we stick with the current structure, maybe I could add something to GridView to make this more apparent/less of a gotcha.

kwalz commented 9 months ago

Yes I think that is where the confusion is, the neighboring box in the same image doesn't get an updated concept name in the gridview thumbnail view--it still had Tomopteris so we are assuming only one box label changed to tomopterid eggcase, until we reload the image set. If the neighboring label changed at the same time in the thumbnail view, we would remember that this is one of those occasions where there are two (or more) box associations on the same line of annotation.