Stop installing typing on Python 3.5+

mbarkhau / bumpver

BumpVer: Automatic Versioning

https://github.com/mbarkhau/bumpver

MIT License

199 stars 36 forks source link

Stop installing typing on Python 3.5+ #148

Closed pquentin closed 4 years ago

pquentin commented 4 years ago

Installing https://pypi.org/project/typing/ is not needed on Python 3.5+. Additionally, a bug in pip means that having typing from PyPI breaks some commands on Python 3.7 and 3.8. Our only dependency that installed typing inconditionally is pycalver, so this pull request fixes the issue.

Thanks!

mbarkhau commented 4 years ago

Indeed, have this fixed already on other similar projects. Thanks for the PR!