search

mbest / knockout-deferred-updates

Deferred Updates plugin for Knockout <=3.3.0
http://mbest.github.io/knockout-deferred-updates/
134 stars 23 forks source link

newCallback used out of scope #9

Closed Digitaledgestudios closed 11 years ago

Digitaledgestudios commented 11 years ago

In the replacement subscribe function (subFnObj[subFnName] = function(...)), the variable newCallback is used out of scope.

mbest commented 11 years ago

The scope is actually okay since an if statement doesn't create a new scope. But I do agree that it could be more obvious. I've updated it to be so. Thanks for the input!