mblackgeo / flask-cognito-lib

A Flask extension that supports protecting routes with AWS Cognito following OAuth 2.1 best practices
https://mblackgeo.github.io/flask-cognito-lib/
MIT License
57 stars 15 forks source link

feat: decorator use config from app context #43

Closed lokeoke closed 3 months ago

lokeoke commented 5 months ago

Description

First commit https://github.com/mblackgeo/flask-cognito-lib/pull/43/commits/e54226b4c841b4a3a145b05320f07d595155b214 demonstrates the issue where custom Config class is provided but decorator does not respect the override.

Second commit https://github.com/mblackgeo/flask-cognito-lib/pull/43/commits/974c11ce08cb927bf13b15f595f53824956ae2b3 resolves the issue by getting the config from the application context.

Resolves:

Depends on:

ToDo:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e165ab8) to head (566bbf0). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #43 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 9 9 Lines 397 398 +1 ========================================= + Hits 397 398 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mblackgeo commented 3 months ago

Hey @lokeoke, is this one ready for review again please?

lokeoke commented 3 months ago

Hey @lokeoke, is this one ready for review again please?

Hello @mblackgeo, Yes, I'd say it is ready.