search

mblayman / markwiki

:warning: UNMAINTAINED: A simple wiki using Markdown
BSD 2-Clause "Simplified" License
29 stars 14 forks source link

allow custom template/static folders #2

Closed ghost closed 11 years ago

ghost commented 11 years ago

This might not fit with the KISS idea of MarkWiki but I wanted to be able to specify custom template and static dirs to override the default theme. Templates are easy since you can just modify the jinja2 loader but static_folder requires either subclassing Flask or loading the user config early and passing a static_folder value to the Flask object initialization.

I haven't really looked into your frozen-flask related code yet so this commit might break that in new and interesting ways.

There's also a snippet offering an alternative method of implementing this but making it work is beyond my meagre OOP skills.

http://flask.pocoo.org/snippets/102/

mblayman commented 11 years ago

hakase, Thanks for the contribution. I've only taken a thirty second glance at the diff because I've been on work travel, but it looks pretty good. I'll probably merge it soon when I have some time to beef it up with some documentation. Since yours is the first external contribution, I need to add some details like a contributors file and development guidelines. I'd like to think on it.