search

mboersma / cluster-api-charts

Helm charts to provision workload clusters for Cluster API Providers
Apache License 2.0
2 stars 6 forks source link

add aks-aso chart #3

Closed nojnhuh closed 6 months ago

dtzar commented 6 months ago

I also recommend putting in a basic readme at the root so people know the difference between this chart and the other CAPZ AKS chart.

mboersma commented 6 months ago

Apprently helm-lint is overly strict with the maintainers: field in Chart.yaml. It can't be empty and name must be a valid GitHub handle. I was investigating this in #7.

That may be fine for us, or we could consider disabling that check.

dtzar commented 6 months ago

No, I think we should adhere to the lint with maintainers. It's easy to add that field in there. The linter doesn't make you maintain the chart if you put your name in there 😅

nojnhuh commented 6 months ago

Sorry, I'm not sure I'll be able to get back to this soon. @dtzar @mboersma Could you please make the follow-up changes?

mboersma commented 6 months ago

/assign

mboersma commented 6 months ago

Oops, sorry @dtzar I added a README.md after you approved this. PTAL whenever you have a chance.