search

mbrlabs / Lorien

Infinite canvas drawing/whiteboarding app for Windows, Linux and macOS. Made with Godot.
MIT License
5.54k stars 240 forks source link

Grid Size: ability for user to change #197

Closed johnblat closed 1 year ago

johnblat commented 2 years ago
johnblat commented 2 years ago

I'm going to work on this. I'll submit it when done and it see if it is good.

mbrlabs commented 2 years ago

Good idea, but this should't be t be in the toolbar. It's reserved for tools which you use regularly and i think you do that maybe once or twice with the grid size (if at all) and then you are done.

See also: #175

johnblat commented 2 years ago

@mbrlabs Should it go in only the settings dialogue then?

mbrlabs commented 2 years ago

Yes ;)

johnblat commented 2 years ago

What tab should this setting go under?

mbrlabs commented 2 years ago

Appearance would be good i think

johnblat commented 2 years ago

@mbrlabs should there be a default_grid_size setting or a grid_size setting, or both?

mbrlabs commented 2 years ago

Not sure what you mean by that. To start i suggest to just add one gird size setting to the settings dialog and don't save it in the actual file at all. So it's purely visual. After that i planned to implement different grid types (see the linked issue in the comment above). Then we can maybe think about putting grid size info into the save file.

mbrlabs commented 1 year ago

Implemented in #199