Reconnect fix. - Githubissues

mbroadst / qamqp

AMQP 0.9.1 implementation for Qt

Other

151 stars 127 forks source link

Reconnect fix. #63

Closed dkormalev closed 7 years ago

dkormalev commented 7 years ago

Adds forceDisconnectFromHost() method to QAmqpClient to immediately disconnect underlying socket;
Fixes issue when one calls disconnectFromHost while reconnectTimer is alive;
Properly disconnects underlying socket before another connectToHost call when socket is already connected.

mbroadst commented 7 years ago

can you explain the rationale for switching from a singleshot timer to needing a fully allocated QTimer for reconnect? (It occurs to me that you wouldn't have had to fix the second bullet point if you hadn't added a QTimer for reconnect).

Also, regarding forceDisconnectFromHost, I think it should more closely follow the API of QAbstractSocket and use the term abort

dkormalev commented 7 years ago

+1 for abort, will replace. BTW, probably with this naming it shouldn't send close message but simply disconnects, what do you think?

About fully allocated QTImer. It is still singleShot. The reason why I need it allocated somewhere to be able to stop it at disconnectFromHost or new connectFromHost.

mbroadst commented 7 years ago

Yeah I agree, if you're forcing the connection to abort there shouldn't be any expectation that the action is graceful.

mbroadst commented 7 years ago

LGTM, thanks for the contribution