search

mbsalers / google-refine

Automatically exported from code.google.com/p/google-refine
Other
0 stars 0 forks source link

[ char in tablename makes Refine unable to save in Excel format #574

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I guess I've found a bug in Google Refine (last stable version for mac).

If you want to export a table in excel format and its name contains a special 
char such as "[", google refine crashes and doesn't save it.

Original issue reported on code.google.com by distant....@gmail.com on 7 May 2012 at 5:59

GoogleCodeExporter commented 8 years ago 
Could you please name the Google Refine version + iOS version + an example of a 
name that crashes?

Original comment by j...@tekii.com.ar on 8 May 2012 at 1:26

GoogleCodeExporter commented 8 years ago 
It's confirmed also for refine 2.5 in Linux.
It seems that spetial characters are not replaced before saving the file in 
XlsExporter.java: 83 
And poi, does not support this in the filename:

    never null
    minimum length is 1
    maximum length is 31
    doesn't contain special chars: : 0x0000, 0x0003, / \ ? * ] [
    Sheet names must not begin or end with ' (apostrophe)

http://poi.apache.org/apidocs/org/apache/poi/ss/util/WorkbookUtil.html

I upload a posible patch for this.

Original comment by j...@tekii.com.ar on 8 May 2012 at 2:17

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 18 Sep 2012 at 8:11

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 12 Oct 2012 at 7:16

GoogleCodeExporter commented 8 years ago 
Thanks for the patch!  Patch applied in r2582.  Look for the fix in the 2.6 
release.

Original comment by tfmorris on 12 Oct 2012 at 11:06

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 12 Oct 2012 at 11:07