search

mc2-center / csbc-pson-dcc

Data coordination resources for the NCI CSBC and PS-ON consortia
1 stars 4 forks source link

Greek letters in publication title will not redirect to its "card" correctly #101

Closed vpchung closed 3 years ago

vpchung commented 3 years ago

I'm not sure if this is the appropriate place to address this issue, but I noticed this publication:

Screen Shot 2021-03-24 at 5 50 58 PM

will not open correctly on the portal. Judging from the query parameter in the URL, I'm assuming this is from the alpha character in the title:

Screen Shot 2021-03-24 at 6 13 47 PM

@jaeddy Should I simply have the curator app change all Greek letters to their respective names?

jaeddy commented 3 years ago

Hmm... I'll see if there's a way to fix this in the portal config (e.g., maybe we can key the link query on pubMedId instead of publicationTitle).

vpchung commented 3 years ago

I think pubMedId would make for a cleaner URL as well!

vpchung commented 3 years ago

@jaeddy I saw in the JIRA ticket that you are proposing using publicationId as the query parameter instead of publicationTitle.

I agree that using publicationId will be better than publicationTitle -- plus it'll be consistent with how the dataset cards are queried, since they use datasetId. The only concern I have is that I had updated the curator app so that it would not create new File entities for publications; instead, it would just create a new row in the Portals - Publication Merged table. Should I re-add that entity creation step? Otherwise, we will probably run into the same issue as above, in that a card will not properly display for the new publications (since there's no associating publicationId).

jaeddy commented 3 years ago

Oh, crap - you're right. I forgot about that. I think we can just use pubMedId for now then (assuming we still annotate that for everything), and maybe switch to publicationId later. Can you chime in on the Jira ticket to clarify?

vpchung commented 3 years ago

@jaeddy Following up on the discussion from the JIRA ticket, would it be appropriate to just replace the publicationTitle column with pubMedId? Or do we explicitly need publicationTitle in the schemas for Datasets and Tools?

(I did look back at our CSBC/PS-ON data model diagram, but I can't really tell which column is acting as the foreign key between publications and datasets/tools. I'm hoping that means we can just change what we use as the FK?)