mc2-center / csbc-pson-dcc

Data coordination resources for the NCI CSBC and PS-ON consortia
1 stars 4 forks source link

Tool cards TODO #23

Closed jaeddy closed 2 years ago

jaeddy commented 4 years ago

@bswhite, @vpchung - I'm attempting to capture and track issues that need to be cleaned up with tools annotations and cards. Let me know if there's anything I missed, or if you have thoughts on any of the specific tasks.

image

Optional:

vpchung commented 2 years ago

@jaeddy

Add secondary label (PUBLICATION) for publication column

Done! It is formatted as the publication title.

Finalize PUBLICATION secondary label link destination (i.e., PubMed vs. Explore/Publications/DetailsPage vs. filtered Explore/Publications page)

The current destination is to the publication details card.

Add secondary label (THEME) for theme column

The new tools table does not have theme, so I opted to include topic as a secondary label instead.

Additionally, now that we have more information to display about tools, we could make it so that clicking on a tools card redirects to a details page (much like grants, publications, datasets):

Screen Shot 2022-02-21 at 8 57 28 PM

jaeddy commented 2 years ago

Awesome, @vpchung! Do these fixes need any additional review/validation, or do you think it's fine to close this issue?

vpchung commented 2 years ago

I think we can close this issue now (will do so now)! Ongoing discussion as to what information to display on the tools card is being tracked in this JIRA ticket :)