Run the tests using GitHub CI

mc706 / changelog-cli

A Command Line Interface that makes it easy to manage a helpful Changelog

MIT License

17 stars 15 forks source link

Run the tests using GitHub CI #27

Closed movermeyer closed 3 years ago

movermeyer commented 3 years ago

Fixes #25

Runs the tests, mypy, pyre, and prospector on every commit.

As compared to the existing TravisCI config:

This doesn't test against nightly. It doesn't appear that GitHub Actions offers that.
This runs the static analysis tools

mc706 commented 3 years ago

Im taking a look into seeing if we can use the matrix.version flag as a pass-in variable for the contianer. That way we could use images like python-3.7:alpine which would allow us to not reinstall python on every run and download much faster.

However that is also thinking coming from a paid gitlab account where we paid for execution time instead of having free actions because it is open source. So less of a benefit but I still feel like faster_ci > slower_ci nevertheless.

movermeyer commented 3 years ago

I'm taking a look into seeing if we can use the matrix.version flag as a pass-in variable for the container.

@mc706

GitHub Actions unfortunately doesn't work like that. You can't choose an arbitrary Docker image as the base image. You use one of their "Runners" using runs-on that forms the base machine.

That said, the ubuntu-latest runner already has the latest version of each of the versions of Python that we are using, so no time is lost installing Python itself.