search

mcMMO-Dev / mcMMO-Classic

mcMMO Classic.
https://www.spigotmc.org/resources/official-mcmmo-classic.2445/
Other
37 stars 44 forks source link

Duplication Bug when used with Slimefun Plugin #44

Open Goonhaven opened 5 years ago

Goonhaven commented 5 years ago

When using a Block-Placer from Slimefun (Bukkit link / GitHub developer link) to place ore blocks this is counted as a natural block, so the Mining skill's doubling chance is applied, which enables one to get unlimited valuable ores using a simple redstone and hopper circuit with a silk touch pickaxe.

I was debating whether to post it on the Slimefun issues github or here, as functionalities from both plugins are to blame, but I would assume it's easier to implement a fix for mcmmo by checking if a block was generated by a machine from that plugin or not.

t00thpick1 commented 5 years ago

I looked into their code, there isn't really a way for us to handle this on our end, they don't throw any events when they set the block types. You will have to ask their devs to either directly set mcMMO placestore i.e. mcMMO.getPlaceStore().setTrue(block) or provide an event so someone else can.

mav2020 commented 4 years ago

I know this is old, but apparently the Block Placer will fire a BlockPlacerPlaceEvent.