search

mcMMO-Dev / mcMMO

The RPG Lover's Mod!
https://mcmmo.org
GNU General Public License v3.0
1k stars 864 forks source link

Option to disallow salvage interactions for traded items #4377

Open Silthus opened 3 years ago

Silthus commented 3 years ago

Villagers can trade you emeralds for their armor or tools and then you can salvage those with a high enough mcMmo Skill getting back the raw diamonds (or other materials).

This allows creating large quantities of diamonds (which should be rare).

Could there be an option to disallow salvaging villager traded items?

nossr50 commented 3 years ago

Yeah this can be done, I'll look into it.

rybuilder23 commented 3 years ago

i would love this.

On my server we have a diamond economy. and now i have turned diamond salvage off with permssions.

rybuilder23 commented 3 years ago

Can this still be looked at? Or is it low on the to-do list ?

nossr50 commented 3 years ago

It's higher up than other things, I have a list of about 5-10 things that I pick from to work on day to day, its among those, but among those its been a lower priority. I am also going to focus on Tridents & Crossbows, which may delay this feature a bit longer. It could spring up any time though, maybe this week if I find time for it.

zaphod77 commented 2 years ago

Note that if this is somehow caught, you can still combine two together to make a third, and this new one will probably be salvageable, because it will no longer be sourced from a villager. There's also grindstones, which probably won't preserve the property blocking salvage either.

I think the correct choice is to just flat out block salvage of all diamond stuff. and probably netherite as well. You can already do enough by salvaging iron, and that IS renewable.

Everything else that would somehow maybe allow renewable diamonds doesn't actually work as far as I know, because of player placed block checks. Except for pot smashing. which is very slow.

zaphod77 commented 1 year ago

okay netherite is not an issue, because you only get back scraps. but diamonds are still very definitely an issue from the armor, weapon, and toolsmiths. and this does completely break diamond economies.

Yeah, mining and excavation do get you a lot of diamonds, but it still doesn't make them renewable unless there's a resource world.

So unless you can make repairing/renaming, and grindstoing preserve the "can't salvage" property, the feature won't help. In particular, crafting grid repairs are almost certain to strip the flag preventing salvage.