search

mcMMO-Dev / mcMMO

The RPG Lover's Mod!
https://mcmmo.org
GNU General Public License v3.0
1.01k stars 868 forks source link

Fix AlchemyBrewTask NPE, Fix blastMiningDropProcessing (IllegalArgumentException: ... isn't an item) #5082

Closed IAISI closed 2 months ago

IAISI commented 2 months ago

Fix McMMOPlayerBrewEvent NPE in AlchemyBrewTask#finish Fix blastMiningDropProcessing attempting to create ItemStacks from Materials that don't have valid items.

IAISI commented 2 months ago

Related: https://github.com/mcMMO-Dev/mcMMO/issues/5073

nossr50 commented 2 months ago

Firstly, thank you for contributing. This PR has some problems, so I'll manually take in your fix for Mining, but the Alchemy one isn't appropriate. In the future, split up your fixes into multiple PRs.