mcagov / beacons

The Beacons registration service
MIT License
4 stars 1 forks source link

Uplift password management for ECS tasks to pass in secrets using AWS Secrets Manager #14

Closed matthew-a-carr closed 3 years ago

matthew-a-carr commented 3 years ago

Overview

The DB password for the RDS PostgreSQL instance is passed in using GitHub secrets, which will ensure that the secrets are encrypted before they reach the runner but is not optimal as it will mean that the secrets exposed to anyone who has access to the ECS task definition within the AWS console.

A more secure solution would be to look at storing the secrets in AWS Secrets Manager and injecting those using the secrets key in the ECS task definition. See link below.

Links

matthew-a-carr commented 3 years ago

This has been done as part of https://github.com/mcagov/beacons-integration/pull/23

@Ninamma FYI

matthew-a-carr commented 3 years ago

Closed as the secrets for the ECS tasks are passed in using secrets manager arns